Skip to content

Conversation

kazuki43zoo
Copy link
Member

I've improved to raise a exception when property that specified at keyProperty is not found on Jdbc3KeyGenerator. This change is with reference to the implementation of SelectKeyGenerator.
Please review.

@emacarron emacarron merged commit 7164f15 into mybatis:master Sep 19, 2016
@kazuki43zoo kazuki43zoo deleted the Jdbc3KeyGenerator branch September 19, 2016 04:50
@kazuki43zoo
Copy link
Member Author

kazuki43zoo commented Sep 19, 2016

Thanks for merging !! I hope to set a milestone.

@emacarron emacarron added the enhancement Improve a feature or add a new feature label Sep 19, 2016
@emacarron emacarron added this to the 3.4.2 milestone Sep 19, 2016
@emacarron emacarron self-assigned this Sep 19, 2016
harawata added a commit to harawata/mybatis-3 that referenced this pull request Aug 9, 2017
harawata added a commit to harawata/mybatis-3 that referenced this pull request Aug 12, 2017
harawata added a commit to harawata/mybatis-3 that referenced this pull request Aug 12, 2017
harawata added a commit that referenced this pull request Aug 13, 2017
harawata added a commit to harawata/mybatis-3 that referenced this pull request Apr 7, 2018
harawata added a commit that referenced this pull request Apr 10, 2018
Throw exception when keyProperty is not found.
Originally developed by @kazuki43zoo in #782 . But reverted in #1073 to workaround #902 .
h3adache pushed a commit that referenced this pull request May 5, 2018
pulllock pushed a commit to pulllock/mybatis-3 that referenced this pull request Oct 19, 2023
Raise a exception when keyProperty is not found
pulllock pushed a commit to pulllock/mybatis-3 that referenced this pull request Oct 19, 2023
pulllock pushed a commit to pulllock/mybatis-3 that referenced this pull request Oct 19, 2023
pulllock pushed a commit to pulllock/mybatis-3 that referenced this pull request Oct 19, 2023
Throw exception when keyProperty is not found.
Originally developed by @kazuki43zoo in mybatis#782 . But reverted in mybatis#1073 to workaround mybatis#902 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve a feature or add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants