Add dxDrawPrimitive3D and dxDrawMaterialPrimitive3D #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botder
previously requested changes
Jan 12, 2019
Member
botder
left a comment
botder
left a comment
There was a problem hiding this comment.
Run the formatting tool after fixing these.
botder
changed the title
qaisjp
previously requested changes
Jan 12, 2019
Contributor
|
PR is now up to date and I cleaned up requested changes confirming if they were done or not. @CrosRoad95 See my comments, I think there's still some changes that need doing. Regarding function returns, this PR should wait for #821 to resolve. |
Author
|
any update? |
Contributor
|
Dutchman101
previously requested changes
Jul 5, 2019
Member
|
The decision in pull request #821 (Pin down return value on failure) is now settled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Mantis #6064
Syntax:
dxDrawPrimitive3D( primitiveType, postGui, vertex1, vertex2, ... )where vertex is
{x,y,z}or{x,y,z,color}dxDrawMaterialPrimitive3D( primitiveType, texture, postGui, vertex1, vertex2, ... )where vertex is
{x,y,z, u, v}or{x,y,z,color, u, v}Test resource
TestResource
Example result:
Only alpha has issues when 2 rendering on top of each other 😢
https://github.com/multitheftauto/mtasa-blue/pull/760/files#diff-7950232204280a1f9935357a84b79876R80
if someone could help me fix it that would be nice, or we could do this in future