Improved warnings for lua-package #683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 2, 2018 18:09
Previous looks like shit
qaisjp
suggested changes
Nov 3, 2018
Contributor
qaisjp
left a comment
qaisjp
left a comment
There was a problem hiding this comment.
This misnumbers errors for empty files or files that return nil. See example resource nil_require.zip.
qaisjp
suggested changes
Nov 3, 2018
qaisjp
reviewed
Jan 12, 2019
patrikjuvonen
approved these changes
Feb 20, 2019
Contributor
patrikjuvonen
left a comment
patrikjuvonen
left a comment
There was a problem hiding this comment.
I believe this PR is ready to be merged with feature/lua-packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make warnings user friendly
Before
After