-
-
Notifications
You must be signed in to change notification settings - Fork 499
Fix #1708: Force people to opt back into Default release type #1712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
jm2c |
qaisjp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I left a tiny nit, but it's optional / non-blocking.
When a nightly is downloaded from nightly.mtasa.com is the build_type by default 0? Just want to make sure that if someone downloads a nightly from nightly.mtasa.com for the first time, they don't get this message.
The build type is set to We can still check if it's a nightly build or not, but apparently it seems there's no way to check if the client downloaded the nightly directly from nightly.mtasa.com. |
|
I did a lot of digging and just can't find any way to check if the current build was downloaded from nightly.mtasa.com. I have another idea. We could just add another button to the update information box like |
|
What if you make it so that it only changes the build_type (and popup) if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work. We just have to make sure we don't increase the nightly autoupdater above 20670 for a while (a week?). We can still merge things once 20670 has been built, though.
Sets the version settings back to stable build if the client is on 1.5.8. A new subkey gets created in the registry after reverting: