Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Oct 14, 2020

Sets the version settings back to stable build if the client is on 1.5.8. A new subkey gets created in the registry after reverting:

HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Multi Theft Auto: San Andreas All\1.5\Settings\general

image

image

@ghost ghost linked an issue Oct 14, 2020 that may be closed by this pull request
@Woovie
Copy link
Contributor

Woovie commented Oct 14, 2020

we've reset you -> we've reset your update preferences

jm2c

Copy link
Contributor

@qaisjp qaisjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I left a tiny nit, but it's optional / non-blocking.

When a nightly is downloaded from nightly.mtasa.com is the build_type by default 0? Just want to make sure that if someone downloads a nightly from nightly.mtasa.com for the first time, they don't get this message.

@StrixG StrixG added this to the 1.5.8 milestone Oct 14, 2020
@StrixG StrixG added the enhancement New feature or request label Oct 14, 2020
@qaisjp qaisjp modified the milestones: 1.5.8, 1.6 Oct 14, 2020
@ghost
Copy link
Author

ghost commented Oct 14, 2020

When a nightly is downloaded from nightly.mtasa.com is the build_type by default 0? Just want to make sure that if someone downloads a nightly from nightly.mtasa.com for the first time, they don't get this message.

The build type is set to 0x9. It could mean two things: stable or nightly.

We can still check if it's a nightly build or not, but apparently it seems there's no way to check if the client downloaded the nightly directly from nightly.mtasa.com.

@ghost
Copy link
Author

ghost commented Oct 15, 2020

I did a lot of digging and just can't find any way to check if the current build was downloaded from nightly.mtasa.com. I have another idea. We could just add another button to the update information box like Don't Reset.

@qaisjp
Copy link
Contributor

qaisjp commented Oct 15, 2020

What if you make it so that it only changes the build_type (and popup) if the revision == 20669 || revision == 20668?

Copy link
Contributor

@qaisjp qaisjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work. We just have to make sure we don't increase the nightly autoupdater above 20670 for a while (a week?). We can still merge things once 20670 has been built, though.

@ghost ghost merged commit c6f5ae2 into multitheftauto:master Oct 15, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Force people to opt back into Default release type when they update to 1.5.8

6 participants