Skip to content

Add clientside lua function resetBlurLevel #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from Mar 16, 2020
Merged

Add clientside lua function resetBlurLevel #1266

merged 5 commits into from Mar 16, 2020

Conversation

@ghost
Copy link

@ghost ghost commented Mar 1, 2020

This PR adds clientside method named resetBlurLevel which is a starting point for #756

@Woovie
Copy link
Contributor

Woovie commented Mar 1, 2020

Any chance we could get resetPlayerBlurLevel as well?

@ghost
Copy link
Author

ghost commented Mar 1, 2020 •
edited by ghost
Loading

Any chance we could get resetPlayerBlurLevel as well?

Do you mean for server-sided scripts ? I did add this method mainly cause of the above mentioned issue regarding blur level setting. Plus: all (?) reset* methods are clientside only.

@Woovie
Copy link
Contributor

Woovie commented Mar 1, 2020

Yes, server-side too. Nothing about the original issue to me indicates it should be a client method only. Correct me if I'm wrong.

@ghost
Copy link
Author

ghost commented Mar 1, 2020 •
edited by ghost
Loading

Well, no, it didnt indicate that it's meant to be clientside only but i thought it since like i said all reset* methods are clientside.

Gonna add resetPlayerBlurLevel clientside which is an alias to resetBlurLevel.

Imo, we dont need resetPlayerBlurLevel on server-side since the server is not responsible for visual stuff unless it's required when it comes to sync (such as weather, time, minute duration)

@LosFaul
Copy link
Contributor

LosFaul commented Mar 1, 2020

resetBlurLevel on server side doesn't make much sence since it's only a visual effect

@ghost ghost requested a review from Woovie March 1, 2020 19:38
@patrikjuvonen patrikjuvonen added the enhancement New feature or request label Mar 11, 2020
@qaisjp
Copy link
Contributor

qaisjp commented Mar 14, 2020

why is resetPlayerBlurLevel added as just an alias?

@qaisjp qaisjp added the feedback Further information is requested label Mar 14, 2020
@ghost
Copy link
Author

ghost commented Mar 16, 2020

why is resetPlayerBlurLevel added as just an alias?
Made it an alias because the logic behind it is the same. Kinda hate duplicating code.

@qaisjp
Copy link
Contributor

qaisjp commented Mar 16, 2020

Why do we need both?

@ghost
Copy link
Author

ghost commented Mar 16, 2020 •
edited by ghost
Loading

Why do we need both?

I dont really think that we need it but @Woovie wanted to have it added as you can see above.

qaisjp
qaisjp reviewed Mar 16, 2020
View reviewed changes
qaisjp
qaisjp reviewed Mar 16, 2020
View reviewed changes
@qaisjp qaisjp removed the feedback Further information is requested label Mar 16, 2020
@ghost
Copy link
Author

ghost commented Mar 16, 2020

done @qaisjp

qaisjp
qaisjp approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@qaisjp qaisjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@qaisjp qaisjp mentioned this pull request Mar 16, 2020
Closed
@qaisjp
Copy link
Contributor

qaisjp commented Mar 16, 2020

sorry, please see #756 (comment)

@qaisjp qaisjp merged commit f3d80a7 into multitheftauto:master Mar 16, 2020
@ghost ghost deleted the features/resetBlurLevel branch March 19, 2020 14:46
@patrikjuvonen patrikjuvonen added this to the 1.6 milestone Apr 13, 2020
@StrixG StrixG removed the request for review from Woovie October 25, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.5.8

Development

Successfully merging this pull request may close these issues.

5 participants

@Woovie @LosFaul @qaisjp @patrikjuvonen @xLuxy