Make onClientPlayerWeaponFire cancellable

[WADmitry]

Describe the bug
If I cancel onClientPlayerWeaponFire event, it has no effect (player shoots anyway)

To reproduce

addEventHandler( "onClientPlayerWeaponFire", localPlayer, function()
	cancelEvent()
end )

Expected behaviour
Player shouldn't shoot if the event was cancelled.

Version

• server 1.5.6
• client 1.5.6

Additional context

[Citizen01]

Which weapons did you try with ?

[WADmitry]

30 (AK-47), 34 (Sniper), and some other.

[Citizen01]

Ok, just check the code, and we didn't make it so you can cancel that event.
So it works as designed and actually, the wiki doesn't mention that you can.
Events that are canceleable are mentionned in the wiki page of said events.
Your bug can be a feature request instead I guess.
Maybe adding a new event onClientPlayerPreWeaponFire that should be triggered in this method:

mtasa-blue/Client/mods/deathmatch/logic/CClientGame.cpp

Lines 5164 to 5212 in 17b7abf

	bool CClientGame::PreWeaponFire(CPlayerPed* pPlayerPed, bool bStopIfUsingBulletSync)
	{
	pWeaponFirePed = pPlayerPed;
	// Got a local player model?
	CClientPed* pLocalPlayer = g_pClientGame->m_pLocalPlayer;
	if (pLocalPlayer && pWeaponFirePed)
	{
	CClientVehicle* pVehicle = pLocalPlayer->GetRealOccupiedVehicle();
	// Get the CClientNetPlayer class with the specified player ped
	CClientPlayer* pPlayer = g_pClientGame->m_pPlayerManager->Get(pWeaponFirePed, true);
	// Move both players to where they should be for shot compensation
	if (pPlayer && !pPlayer->IsLocalPlayer())
	{
	if (bStopIfUsingBulletSync && pPlayer->IsCurrentWeaponUsingBulletSync())
	return false; // Don't apply shot compensation & tell caller to not do bullet trace
	if (bShotCompensation)
	{
	if (!pVehicle || pLocalPlayer->GetOccupiedVehicleSeat() == 0)
	{
	// Warp back in time to where we were when this player shot (their latency)
	// We don't account for interpolation here, +250ms seems to work better
	// ** Changed ajustment to +125ms as the position of this clients player on the firers screen
	// has been changed. See CClientPed::UpdateTargetPosition() **
	CVector vecPosition;
	unsigned short usLatency = (pPlayer->GetLatency() + 125);
	g_pClientGame->m_pNetAPI->GetInterpolation(vecPosition, usLatency);
	// Move the entity back
	if (pVehicle)
	{
	pVehicle->GetPosition(vecWeaponFirePosition);
	pVehicle->SetPosition(vecPosition, false, false);
	}
	else
	{
	pLocalPlayer->GetPosition(vecWeaponFirePosition);
	pLocalPlayer->SetPosition(vecPosition, false, false);
	}
	}
	}
	}
	}
	return true;
	}

and looking for the "canceled return value" should do the trick ?

[WADmitry]

Events that are canceleable are mentionned in the wiki page of said events

I see. I thought any event can be cancelled.

Thank you, I'll try.

P.S. Should I create a new Issue for the feature request? Or...?

[qaisjp]

P.S. Should I create a new Issue for the feature request? Or...?

no need

[haron4igg]

Would be also good improvement to make
onPlayerWeaponFire cancelable, so we can actually prevent bullets from sync to other players, if player is shooting using cheats.