onPickupLeave+setDimension

[Allerek]

onPickupLeave do not detect the dimension change,idk how about interior.

[botder]

Can you use the Bug report issue template next time? Your description is lacking information.
How to reproduce your bug? What is the expected behavior? What is your server/client version?

[Allerek]

Can you use the Bug report issue template next time? Your description is lacking information.
How to reproduce your bug? What is the expected behavior? What is your server/client version?

1. Create pickup
2. Stand in it, then teleport to other dimension.
   I have the script that makes GUI appear when you hit Pickup the triggerClientEvent with function when you leave the pickup thats hiding the GUI, and it doesnt hide if you change dimension when standing in pickup.
   Client/Server version-Latest Public

[Allerek]

https://youtu.be/4P1k4VyohiM

[botder]

Client

mtasa-blue/Client/mods/deathmatch/logic/CClientPickup.cpp

Lines 196 to 214 in d47332e

	void CClientPickup::Callback_OnLeave(CClientColShape& Shape, CClientEntity& Entity)
	{
	if (IS_PLAYER(&Entity))
	{
	bool bMatchingDimensions = (GetDimension() == Entity.GetDimension()); // Matching dimensions?
	// Call the pickup leave event (source = the pickup that was left)
	CLuaArguments Arguments;
	Arguments.PushElement(&Entity); // The element that left the pickup
	Arguments.PushBoolean(bMatchingDimensions);
	CallEvent("onClientPickupLeave", Arguments, true);
	// Call the player pickup leave event (source = the player that left the pickup)
	CLuaArguments Arguments2;
	Arguments2.PushElement(this); // The pickup that was left (this)
	Arguments2.PushBoolean(bMatchingDimensions);
	Entity.CallEvent("onClientPlayerPickupLeave", Arguments2, true);
	}
	}

Server

mtasa-blue/Server/mods/deathmatch/logic/CPickup.cpp

Lines 514 to 541 in d47332e

	void CPickup::Callback_OnLeave(CColShape& Shape, CElement& Element)
	{
	if (IS_PLAYER(&Element))
	{
	CPlayer& Player = static_cast<CPlayer&>(Element);
	// Matching interior
	if (GetInterior() == Element.GetInterior())
	{
	// Matching dimension
	if (GetDimension() == Element.GetDimension())
	{
	// Is he alive?
	if (!Player.IsDead())
	{
	// Call the onPickupLeave event
	CLuaArguments Arguments;
	Arguments.PushElement(&Player);
	CallEvent("onPickupLeave", Arguments);
	CLuaArguments Arguments2;
	Arguments2.PushElement(this); // pickup
	Element.CallEvent("onPlayerPickupLeave", Arguments2);
	}
	}
	}
	}
	}

Proposed solution

Change CPickup::Callback_OnLeave (server) to match the behavior of CClientPickup::Callback_OnLeave (client):

• Add matchingDimensions parameter
• Trigger for leaving players in different interior and dimension

We could also do the same for CPickup::Callback_OnCollision (client triggers onClientPickupHit even if interior and dimension differs, but server doesn't), but it might break existing scripts.

[qaisjp]

Actually I think it's good that onPickupLeave server-side currently only triggers for matching interiors and dimensions.

I am not sure what to do if the user leaves a pickup by teleporting to another dimension. It should probably trigger the event even though the dimension/interior is different, as the player has technically left the pickup.

I have a hunch that the clientside argument was only added in the name of backwards compatibility

Thoughts @botder?

[botder]

I really dislike keeping backwards compatibility in such cases, because the next scripter might not expect this odd behavior - he probably expects that leaving the pickup's dimension/interior should trigger the event.

[qaisjp]

• Add matchingDimensions parameter [the first half]
• Trigger for leaving players in different interior and dimension [the second half]

I really dislike keeping backwards compatibility in such cases, because the next scripter might not expect this odd behavior - he probably expects that leaving the pickup's dimension/interior should trigger the event.

I agree we should add a fix for the second half. My backwards compatibility comment is only relating to the first half.

I have a hunch that the clientside argument was only added in the name of backwards compatibility

This meant that the client-side event probably originally used to always trigger (regardless of dimension and interior). So they added matchingDimension for people to check instead of breaking BC a little.

My argument is that it is good that onPickupLeave does not trigger when you pickup is in a different dimension. i.e., we should not remove the dimension/interior checks on the server side.

Also, on the client, matchingDimensions should probably be true if the player leaves the pickup's dimension, since the player USED TO BE in the same dimension.

Does that make sense?

[Allerek]

Refresh, is it fixed?