onPlayerTeleport triggers when standing on a destroyed element

[wassmas]

Describe the bug

The onPlayerTeleport event is triggered incorrectly when a player is standing on an object or element that gets destroyed with destroyElement.

Steps to reproduce

addEventHandler("onPlayerTeleport", root, 
function(x, y, z, x2, y2, z2)
    outputChatBox("Teleported from ["..string.format("%.2f, %.2f, %.2f", x, y, z).."] to ["..string.format("%.2f, %.2f, %.2f", x2, y2, z2).."]", root)
end)

Message: Teleported from [-0.22, -0.52, 2.37] to [117.40, 1878.21, 20.80]

Version

MTA:SA Server v1.6-release-23251

Additional context

No response

Relevant log output

Security Policy

• I have read and understood the Security Policy and this issue is not security related.

[MegadreamsBE]

Oh hey. I know what likely is happening here! Those first coordinates are the relative coordinates between the player and the element. This happens when a player is in contact with an element, instead of sending absolute coordinates they switch to relative. This ensures a more stable sync in case this element moves (otherwise others will see the player clipping through, etc).

When the element is destroyed (or the player gets off it), those coordinates switch back to absolute coordinates. Likely the code that handles onPlayerTeleport is not taking in account whether the player was actively touching an element or not, and thus triggering it. Likely the server no longer considers the player as touching, but still received one last packet for it.