setCursorAlpha can change the cursor transparency when the main menu or console is visible

[xLive]

Describe the bug

As the title says, setCursorAlpha function can modify cursor transparency when the main menu/console is visible. The cursor should always be fully visible when they are shown, and servers should not have control over its transparency.

Steps to reproduce

1. Open the main menu or the console.
2. Use setCursorAlpha to change the cursor transparency while the main menu or console is visible.

Version

v1.5.9-release-21622

Additional context

cursorbug.mp4

Security Policy

• I have read and understood the Security Policy and this issue is not security related.

[Lpsd]

I think the best way to handle this would be to queue any calls to setCursorAlpha whilst the main menu or console is visible. There should only be one "call" in the queue at any time (the latest one).

When the player leaves the main menu / console, the cursor alpha is then applied.

[Einheit-101]

I think the best way to handle this would be to queue any calls to setCursorAlpha whilst the main menu or console is visible. There should only be one "call" in the queue at any time (the latest one).

When the player leaves the main menu / console, the cursor alpha is then applied.

But then you need to make the cursor visible again as soon as the player opens console again

[Lpsd]

But then you need to make the cursor visible again as soon as the player opens console again

This is already the case. See here and here

But actually upon further inspection, we don't even need to do what I suggested, since it already restores the server's current cursor alpha upon closing the console/menu. We simply need to stop calls to CStaticFunctionDefinitions::SetCursorAlpha if the main menu or console is currently visible.

[xLive]

We simply need to stop calls to CStaticFunctionDefinitions::SetCursorAlpha if the main menu or console is currently visible.

If I'm not wrong, we also need to update the value of m_fCurrentServerCursorAlpha. Otherwise, this will lead to unexpected behavior for scripts that use getCursorAlpha and setCursorAlpha.