-
Notifications
You must be signed in to change notification settings - Fork 19
Add simple RBS signatures for generated files #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks. |
|
@mtsmfm |
|
@joker1007 Can you rebase this branch onto the latest main? I'd like to see the result for generator workflow and CI failure should be fixed. |
|
@mtsmfm |
Gemfile
Outdated
| gem "benchmark-ips" | ||
| gem "pry-byebug" | ||
| gem "activesupport" | ||
| gem "steep" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| gem "steep" | |
| gem "steep", require: false |
To fix this failure
I know it's already retired though I'd like to not drop old rubies until we face huge difficulties just for my curiosity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joker1007 Can you apply this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joker1007 Poke
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry. I forgot to apply the change.
I fixed it.
|
Sorry for bothering you, could you rebase this branch again? Hopefully this change fixes the generator CI for forked repos |
|
No problem! |
|
Thanks! |
This pull request add rbs signatures for generated files.
Union type and type alias are not supported currently. I handle them as
untypednow.nevertheless, These signatures are useful for type checking and code completion.
I also write Steepfile to enable type checking.
But, I met a mysterious
DuplicatedDeclarationError.Because I couldn't resolve this, some type-checking errors are left.