Skip to content

Use jsonapi struct tags for nested attrs #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2018
Merged

Use jsonapi struct tags for nested attrs #6

merged 1 commit into from
Oct 4, 2018

Conversation

@shwoodard
Copy link

@shwoodard shwoodard commented Oct 4, 2018

This PR

  • makes it so that nested attrs use "jsonapi" struct tag rather than "json" so that json serializer can use the "json" struct tag
  • reuses handleNumeric for parsing identity, ID, values.

This is intended to be the last change to google#99 before merging.

@mrowdy mrowdy merged commit 417d4eb into mrowdy:master Oct 4, 2018
The-Don-Himself added a commit to The-Don-Himself/jsonapi that referenced this pull request May 16, 2020
@The-Don-Himself
Revert "Merge pull request mrowdy#6 from shwoodard/shwoodard-slemgrim…
3850b11 
…-pull-99"

This reverts commit 417d4eb, reversing
changes made to 8b7e0bc.

Debugging an issue which may have been caused by changes since
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shwoodard @mrowdy