No quick fixes available in hlint suggestions

[jneira]

Hi, now i have hlint suggestions with the hie-bios branch i noted that quick fixis not even enabled (it shows No quick fixes available) I've tested it with redundant do and redundant brackets rules.

Maybe it is windows specific (confirmation welcome!)

[fendor]

I tried to reproduce on nixos.
I am not sure, whether I am currently using #67 or hie-bios master, but I have quickfixes available.

[jneira]

Ok, i've analyzed the messages and for me hlint suggestiona has not kind quickfix but refactor, so i guess it would be the cause to not enable the quick fix link in the popup:

• Normal error popup:

2019-12-08 22:08:17.11673 [ThreadId 3] - ---> {"jsonrpc":"2.0","id":46,"method":"textDocument/codeAction","params":{"textDocument":{"uri":"file:///d%3A/dev/ws/haskell/haskell-lsp/src/Language/Haskell/LSP/Core.hs"},"range":{"start":{"line":522,"character":40},"end":{"line":522,"character":44}},"context":{"diagnostics":[{"range":{"start":{"line":522,"character":40},"end":{"line":522,"character":44}},"message":"* Variable not in scope: urix :: J.NormalizedUri\n* Perhaps you meant one of these:\n    `uri' (line 523),\n    `J.uri' (imported from Language.Haskell.LSP.Types.Lens)","severity":1,"source":"bios"}],"only":["quickfix"]}}}
2019-12-08 22:08:17.574557 [ThreadId 4] - <--2--{"result":[{"edit":{"documentChanges":[{"edits":[{"range":{"start":{"line":522,"character":40},"end":{"line":522,"character":44}},"newText":"uri"}],"textDocument":{"uri":"file:///d%3A/dev/ws/haskell/haskell-lsp/src/Language/Haskell/LSP/Core.hs","version":2}}]},"kind":"quickfix","diagnostics":[{"severity":1,"range":{"start":{"line":522,"character":40},"end":{"line":522,"character":44}},"source":"bios","message":"* Variable not in scope: urix :: J.NormalizedUri\n* Perhaps you meant one of these:\n    `uri' (line 523),\n    `J.uri' (imported from Language.Haskell.LSP.Types.Lens)"}],"title":"Replace with uri"},{"edit":{"documentChanges":[{"edits":[{"range":{"start":{"line":522,"character":40},"end":{"line":522,"character":44}},"newText":"J.uri"}],"textDocument":{"uri":"file:///d%3A/dev/ws/haskell/haskell-lsp/src/Language/Haskell/LSP/Core.hs","version":2}}]},"kind":"quickfix","diagnostics":[{"severity":1,"range":{"start":{"line":522,"character":40},"end":{"line":522,"character":44}},"source":"bios","message":"* Variable not in scope: urix :: J.NormalizedUri\n* Perhaps you meant one of these:\n    `uri' (line 523),\n    `J.uri' (imported from Language.Haskell.LSP.Types.Lens)"}],"title":"Replace with J.uri"}],"jsonrpc":"2.0","id":46}

• hlint suggestion popup:

2019-12-08 21:30:11.0032787 [ThreadId 3] - ---> {"jsonrpc":"2.0","id":12,"method":"textDocument/codeAction","params":{"textDocument":{"uri":"file:///d%3A/dev/ws/haskell/haskell-lsp/src/Language/Haskell/LSP/Core.hs"},"range":{"start":{"line":451,"character":3},"end":{"line":451,"character":50}},"context":{"diagnostics":[{"range":{"start":{"line":451,"character":3},"end":{"line":451,"character":50}},"message":"Redundant bracket\nFound:\n  (InitializeCallbacks {onConfigurationChange})\nWhy not:\n  InitializeCallbacks {onConfigurationChange}\n","severity":3,"code":"Redundant bracket","source":"hlint"}],"only":["quickfix"]}}}
2019-12-08 21:30:11.0092765 [ThreadId 4] - <--2--{"result":[{"command":{"command":"90864:applyrefact:applyOne","arguments":[{"hintTitle":"Redundant bracket","start_pos":{"line":451,"character":3},"file":"file:///d%3A/dev/ws/haskell/haskell-lsp/src/Language/Haskell/LSP/Core.hs"}],"title":"Apply hint:Redundant bracket"},"kind":"refactor","diagnostics":[{"severity":3,"range":{"start":{"line":451,"character":3},"end":{"line":451,"character":50}},"code":"Redundant bracket","source":"hlint","message":"Redundant bracket\nFound:\n  (InitializeCallbacks {onConfigurationChange})\nWhy not:\n  InitializeCallbacks {onConfigurationChange}\n"}],"title":"Apply hint:Redundant bracket"}],"jsonrpc":"2.0","id":12}

Should be it a quickfix? it reminds me haskell#1081

But when i tried to aplly the refactor using the light bulb:

It has removed imports and the function above the one with the redundant brackets (but it removed the brackets as well 😆 )

Maybe related haskell#1448

[jneira]

Ok, not sure if hlint suggestions were or could be quick fixes but imo it is not a bug and not related with hie-bios or sure