Skip to content

fix: deno compatibility with firefox #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: deno compatibility with firefox #3535

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9450c5a
Fix deno compatibility
ggodlewski Oct 6, 2025
1a6fcd4
Fix missing arg
ggodlewski Oct 6, 2025
e376a90
Fix lint
ggodlewski Oct 6, 2025
c0bee5b
Fix prettier
ggodlewski Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/firefox/rdp-client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import net from 'net';
import EventEmitter from 'events';
import domain from 'domain';

import { isErrorWithCode } from '../errors.js';

export const DEFAULT_PORT = 6000;
export const DEFAULT_HOST = '127.0.0.1';

Expand Down Expand Up @@ -90,7 +92,17 @@ export default class FirefoxRDPClient extends EventEmitter {

this._rdpConnection = conn;
conn.on('data', this._onData);
conn.on('error', this._onError);
conn.on('error', (err) => {
if (
isErrorWithCode('ECONNREFUSED', err) ||
isErrorWithCode('ENOTFOUND', err) ||
isErrorWithCode('ETIMEDOUT', err)
) {
reject(err);
} else {
this._onError(err);
}
});
conn.on('end', this._onEnd);
conn.on('timeout', this._onTimeout);

Expand Down