[bug 1654250] surface -11 and -15 exit codes in run_command #324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we're hitting -11 exit codes in iscript when we restart scriptworker. Scriptworker would turn a -11 exit code into an
intermittent-task, which would automatically retry the task. However,run_commandturns that -11 exit code into an exit code of 1, which isfailed.Let's surface the -11 and -15 exit codes if they show up in
run_command.If we're worried about how large of a change this is, we could set the default
copy_exit_codestoNoneand only override thecopy_exit_codesin the iscriptrun_commandcalls.Besides the unit tests, I also had a test script where I did
which gave me -11. Setting the exit code through bash seems to translate
-11to245, though.