Skip to content

Conversation

@escapewindow
Copy link
Contributor

@escapewindow escapewindow commented Feb 2, 2021

I think we're hitting -11 exit codes in iscript when we restart scriptworker. Scriptworker would turn a -11 exit code into an intermittent-task, which would automatically retry the task. However, run_command turns that -11 exit code into an exit code of 1, which is failed.

Let's surface the -11 and -15 exit codes if they show up in run_command.

If we're worried about how large of a change this is, we could set the default copy_exit_codes to None and only override the copy_exit_codes in the iscript run_command calls.

Besides the unit tests, I also had a test script where I did

#!/usr/bin/env python

from scriptworker_client.exceptions import TaskError

t = TaskError("foo", exit_code=-11)
print(t.exit_code)

which gave me -11. Setting the exit code through bash seems to translate -11 to 245, though.

@escapewindow
Copy link
Contributor Author

Hm. I'm wondering if we should also add 245 and 241 to the scriptworker reversed_statuses...

@escapewindow
Copy link
Contributor Author

Tested, along with mozilla-releng/scriptworker#480 , in https://treeherder.mozilla.org/jobs?repo=try&revision=3a178a506ea21ac97a82dfb434fb1d0e5117ec61&selectedTaskRun=MQsIpnh9S5mIzih6fsWEJw.9

Took me a while to figure out what was going on. reversed_statuses hasn't ever worked, as far as I can tell. =
Works now...

@escapewindow
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants