Skip to content

Support worker threads with custom current working directory #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Support worker threads with custom current working directory #131

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ddebc6
fix: updated worker thread detection
LakitnaRabobank Apr 3, 2020
6dbad20
fix: support for node < 12
LakitnaRabobank Apr 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions lib/util/resolveCommand.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,22 @@ const path = require('path');
const which = require('which');
const pathKey = require('path-key')();

let isMainThread;

try {
isMainThread = require('worker_threads').isMainThread;
} catch (error) {
// Worker threads are not supported in the current node version
// because of this we're always in the main thread
isMainThread = true;
}

function resolveCommandAttempt(parsed, withoutPathExt) {
const cwd = process.cwd();
const hasCustomCwd = parsed.options.cwd != null;
// Worker threads do not have process.chdir()
const shouldSwitchCwd = hasCustomCwd && process.chdir !== undefined;
// Worker threads do not have process.chdir() so we should only use it if
// we're running in the main thread
const shouldSwitchCwd = hasCustomCwd && isMainThread;

// If a custom `cwd` was specified, we need to change the process cwd
// because `which` will do stat calls but does not support a custom cwd
Expand Down