Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

Conversation

@dopa
Copy link

@dopa dopa commented May 8, 2014

I added the ability to pass in scroll_selector, such as '#people'. Also refactored static "check_binded" variable to be stored as data on the scrollable element.

I added the ability to pass in scroll_selector, such as '#people'. Also refactored static "check_binded" variable to be stored as data on the scrollable element.
mlisowsk added a commit to mlisowsk/jquery.appear that referenced this pull request May 24, 2023
…r#30 from dopa on original repo

Explain options in README.md
@mlisowsk
Copy link

mlisowsk commented May 24, 2023

Hi @dopa I am using your proposed code in my fork and found a bug:
You need to declare the opts var in the top scope otherwise calling $.force_appear() will throw an exception for an undefined variable opts. I use var opts = defaults = ... to avoid exceptions in case $.force_appear() is called before any $.appear() call.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants