Skip to content

Increase max upload size #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

andrewnicols
Copy link
Contributor

This increases the standard maximum upload file size to 200M, which is a much more realistic size for development.

This also requires a bump in the maximum post size.

@andrewnicols andrewnicols force-pushed the increaseDefaultUploads branch from a3db630 to 6ab8ce7 Compare March 19, 2023 14:33
@andrewnicols
Copy link
Contributor Author

andrewnicols commented Mar 19, 2023

I've had to rebase this issue on #170 because we need to be able to override the default settings using the new PHP_INI- environment variables.

I've added tests for:

  • upload_max_filesize:
    • PHP default is 2M
    • a value of 200M is set in our supplied .ini file
    • a value of 20M is set as an environment variable - the environment should win.
  • post_max_size:
    • PHP default is 8M
    • a value of 206M is set in our suppled .ini file - our .ini should win

This increases the standard maximum upload file size to 200M, which is a
much more realistic size for development.

This also requires a bump in the maximum post size.
@andrewnicols andrewnicols force-pushed the increaseDefaultUploads branch from 6ab8ce7 to c89c28e Compare March 20, 2023 09:29
@stronk7 stronk7 merged commit b68b255 into moodlehq:master Mar 20, 2023
@stronk7
Copy link
Member

stronk7 commented Mar 20, 2023

Merged, thanks. Backporting this, together with #170 , to php >= 74 now.

@stronk7
Copy link
Member

stronk7 commented Mar 20, 2023

Done: Backported to >= php74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants