Add net472 back to Mono.Debugging.Soft #351
Conversation
Xamarin.Android has build tasks and tests that target net472 which won't build without multitargeting Mono.Debugging.Soft.
|
@nosami I don't have permission to request reviewers, but hopefully you can take a look at this when you have a moment :) |
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>net6.0</TargetFrameworks> | ||
| <TargetFrameworks>net6.0;net472</TargetFrameworks> |
There was a problem hiding this comment.
We're working towards slowly phasing out net472, because I think that implies a dependency on Mono, so I wonder if this should conditionally target net472 and net6.0.
There was a problem hiding this comment.
Do you want me to add some property that could control multitargeting this in this current PR, or is this something we should do in a future PR?
Both Mono.Debugger.Soft and Mono.Debugging are targeting net6.0 and net472, so I figured this removal of net472 was maybe just an oversight.
There was a problem hiding this comment.
I'll deal with it if it becomes a problem then! I saw that net472 shells out to mono when building, so when we remove mono, if it breaks, I'll do that.
2 participants
Xamarin.Android has build tasks and tests that target net472 which won't
build without multitargeting Mono.Debugging.Soft.