DRIVERS-3162 Add test for SRV hostname validation when resolver and r… #1787
Conversation
…esolved hostnames are identical with three domain levels
| @@ -48,6 +48,10 @@ For this test, run each of the following cases: | |||
| - the SRV `mongodb+srv://mongo.local` resolving to `test_1.my_hostmongo.local` | |||
| - the SRV `mongodb+srv://blogs.mongodb.com` resolving to `cluster.testmongodb.com` | |||
|
|
|||
| ### 5. Do not throw when return address is identical to SRV hostname and SRV hostname has three or more `.` separated parts | |||
|
|
|||
| - the SRV `mongodb+srv://blogs.mongodb.com` resolving to `blogs.mongodb.com` | |||
There was a problem hiding this comment.
Should we add the case where mongodb+srv://blogs.mongodb.com resolves to test.blogs.mongodb.com? Or is that already tested elsewhere?
There was a problem hiding this comment.
Not sure. We're adding the 5th test because the previous 3 tests confirm that an error is raised. Similar to the first test in which we confirm there is no error, this test confirms there is no error. IIUC, a response of test.blogs.mongodb.com is valid because the domains match, but the hostnames are not identical so we're not looking for this particular success in this test case.
|
@dariakp @ShaneHarvey Just noticed this stalled, what's next (if you happen to recall, else I'll review!) ? |
|
@aclark4life The tests are pretty straightforward here and I think the only thing we were waiting on was dev prod; as Shane is the eng lead on the ticket I'll defer to his judgment on what's left to finish this spec change - you have my tentative approval modulo lint issues. It's a good idea to include a link to the driver PR/CI in the description though, for future reference. |
|
@aclark4life these changes LGTM but https://jira.mongodb.org/browse/DEVPROD-17419 added the real SRV hosts so we can actually add JSON spec tests for these two cases. Should we update this PR to remove the prose test and add the spec test files? JSON files are easier for drivers to implement so that would be my preference. |
…esolved hostnames are identical with three domain levels
Please complete the following before merging:
clusters, and serverless).