Skip to content

DRIVERS-2938: Remove MONGODB-CR from spec tests #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2024
Merged

DRIVERS-2938: Remove MONGODB-CR from spec tests #1611

merged 1 commit into from
Jul 15, 2024

Conversation

@sanych-sun
Copy link
Member

@sanych-sun sanych-sun commented Jul 12, 2024

Changes to spec tests to close the DRIVERS-2938 Remove MONGODB-CR from spec tests

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver (tested in custom patch for CSharp Driver, will update with PR once other MongoDB 4.0 related issues will get sorted).
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@sanych-sun sanych-sun requested review from a team as code owners July 12, 2024 19:38
@sanych-sun sanych-sun requested review from JamesKovacs and removed request for a team July 12, 2024 19:38
@sanych-sun sanych-sun changed the title Drivers2938 DRIVERS-2938 Remove MONGODB-CR from spec tests Jul 12, 2024
@sanych-sun sanych-sun requested a review from blink1073 July 12, 2024 21:45
@sanych-sun sanych-sun changed the title DRIVERS-2938 Remove MONGODB-CR from spec tests DRIVERS-2938: Remove MONGODB-CR from spec tests Jul 12, 2024
blink1073
blink1073 approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sanych-sun sanych-sun merged commit 82be6f2 into mongodb:master Jul 15, 2024
@sanych-sun sanych-sun deleted the drivers2938 branch July 15, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaneHarvey ShaneHarvey ShaneHarvey left review comments

@blink1073 blink1073 blink1073 approved these changes

@JamesKovacs JamesKovacs Awaiting requested review from JamesKovacs JamesKovacs is a code owner automatically assigned from mongodb/dbx-spec-owners-auth

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sanych-sun @blink1073 @ShaneHarvey