DRIVERS-1993: Convert ADL spec tests to unified test format #1545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Mar 8, 2024
Synced with mongodb/specifications#1545 Moves isAtlasDataLake() function to FunctionalTestCase, since it is now shared across test files. Fixes typo in ADL prose test comment.
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Mar 11, 2024
Synced with mongodb/specifications#1545 Moves isAtlasDataLake() function to FunctionalTestCase, since it is now shared across test files. Fixes typo in ADL prose test comment.
jmikola
commented
Mar 11, 2024
| command: | ||
| getMore: { $$type: [ int, long ] } | ||
| # collection name will be an internal identifier | ||
| collection: { $$type: string } |
There was a problem hiding this comment.
The original tests didn't assert getMore or collection at all, but we can now use $$type.
alcaeus
approved these changes
Mar 12, 2024
|
Note: the failed link check on https://github.com/10gen/mongohouse/blob/master/README.md is a false positive, as the file exists in a private repository. |
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Mar 12, 2024
Synced with mongodb/specifications#1545 Moves isAtlasDataLake() function to FunctionalTestCase, since it is now shared across test files. Fixes typo in ADL prose test comment.
|
Link check will be fixed in #1549 I didn't realize that was a permanent lint failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/DRIVERS-1993
POC: mongodb/mongo-php-library#1250