Skip to content

test(NODE-4605, NODE-4597, NODE-4618): sync latest change stream unified tests #3402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2022
Merged

test(NODE-4605, NODE-4597, NODE-4618): sync latest change stream unified tests #3402

merged 3 commits into from
Sep 12, 2022

Conversation

@baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Sep 9, 2022 •
edited
Loading

Description

What is changing?

This PR syncs the unified change stream tests to the latest in the specs repo.

There are three drivers tickets covered here. I broke it out into one commit per drivers ticket:

@baileympearson baileympearson changed the title test: add change stream cluster time unified tests test(NODE-4605, NODE-4597, NODE-4618): sync latest change stream unified tests Sep 9, 2022
@baileympearson baileympearson marked this pull request as ready for review September 9, 2022 14:39
@baileympearson baileympearson removed the wip label Sep 9, 2022
nbbeeken
nbbeeken reviewed Sep 9, 2022
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've added some serverless: forbid settings here but the tests aren't being run on serverless at all, suspicious!

These were the only ones missing forbid

@nbbeeken nbbeeken added the Team Review Needs review from team label Sep 9, 2022
@nbbeeken nbbeeken merged commit 12e951b into main Sep 12, 2022
@nbbeeken nbbeeken deleted the NODE-4597-sync-change-stream-tests branch September 12, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nbbeeken nbbeeken nbbeeken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Team Review Needs review from team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baileympearson @nbbeeken