feat(NODE-4607): add exports needed by legacy client #3396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
added
the
Primary Review
dariakp
requested changes
Sep 7, 2022
dariakp
added
Team Review
dariakp
approved these changes
Sep 7, 2022
baileympearson
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Added:
What is the motivation for this change?
This is not a feature for users, but we need these exports at the top level to make the legacy wrapper package be able to import without using nested paths.
Open Q:
I want to add a little unit test that checks our exports, is checking just keys fine? and is there any obvious test organization changes you see?
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>