Skip to content

Conversation

@emadum
Copy link
Contributor

@emadum emadum commented Jul 2, 2021

No description provided.

@emadum emadum force-pushed the NODE-3095/4.0/create-timeseries-collection branch from 2b99dec to 0784c95 Compare July 2, 2021 17:17
@emadum emadum requested a review from nbbeeken July 2, 2021 17:58
@emadum emadum added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 2, 2021
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS suggestion, what do you think?

@emadum emadum requested a review from nbbeeken July 2, 2021 20:01
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jul 6, 2021
@nbbeeken nbbeeken requested a review from dariakp July 6, 2021 14:17
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor suggestion

@nbbeeken nbbeeken merged commit c145c91 into 4.0 Jul 8, 2021
@nbbeeken nbbeeken deleted the NODE-3095/4.0/create-timeseries-collection branch July 8, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Needs review from team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants