feat(NODE-3331): offer downleveled types for legacy typescript versions #2859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadum
suggested changes
Jun 25, 2021
Contributor
emadum
left a comment
emadum
left a comment
There was a problem hiding this comment.
Just confirming about xtrace being on, otherwise LGTM!
.evergreen/run-checks.sh
Outdated
| export NVM_DIR="${NODE_ARTIFACTS_PATH}/nvm" | ||
| [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" | ||
|
|
||
| set -o xtrace |
Contributor
There was a problem hiding this comment.
Was this meant to stay here or is it left over from development? I find it generally clutters up logs having this on (and it can leak sensitive data).
Contributor
Author
There was a problem hiding this comment.
Just testing, now that I have the useful "echo"s we dont need this
durran
approved these changes
Jun 28, 2021
nbbeeken
force-pushed
the
NODE-3331/downlevel-dts
branch
from
ef608be to
42e86ae
Compare
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downlevel-dts is now run when ever defintions are generated and our package points typescript versions equal to 4.0.2 and older to these defintions. They target the lowest version downlevel-dts supports which is 3.4. I added a check to our CI to make sure that 4.0.2 will use and remain compatible with these types.