chore: update AutoEncryptionOptions with GCP and Azure MONGOSH-527 #2701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'll quickly update again to reflect the "more strict" typings I've used in |
rose-m
force-pushed
the
MONGOSH-527-update-auto-encryption-typings
branch
from
cfbe0e7 to
bf849c6
Compare
Contributor
|
@rose-m If we merge and release the types in mongodb-client-encryption then can we re-export those? Are they identical? |
Contributor
Author
|
Hey @nbbeeken - yeah I've essentially literally copied over the |
nbbeeken
approved these changes
Jan 19, 2021
Contributor
nbbeeken
left a comment
nbbeeken
left a comment
There was a problem hiding this comment.
Actually I realize I think we'll want to keep these in the driver since CSFLE is an optional dependency, we wouldn't want to make it required just for the types. Regardless, LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What changed?
This updates the type definition of the
AutoEncryptionOptionsto support GCP and Azure KMS providers. This is in line with mongodb/libmongocrypt#154.Are there any files to ignore?
None