fix: hasAtomicOperator check respects toBSON transformation #2696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain documents cannot contain atomic operators i.e. keys with a leading dollar sign, documents can contain toBSON transformation functions that would modify such keys the check now respect the transformation NODE-2741
emadum
approved these changes
Jan 13, 2021
Contributor
emadum
left a comment
emadum
left a comment
There was a problem hiding this comment.
Stylistic nit, I'd prefer a ternary expression inside Object.keys rather than the docToTest variable, but LGTM 👍
durran
requested changes
Jan 14, 2021
Member
durran
left a comment
durran
left a comment
There was a problem hiding this comment.
Although it's a minor fix would it be possible add a test to show the behaviour works please?
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain documents cannot contain atomic operators
i.e. keys with a leading dollar sign, documents can contain
toBSON transformation functions that would modify such keys the check
now respect the transformation
NODE-2741