Skip to content

Conversation

@lantoli
Copy link
Member

@lantoli lantoli commented Oct 16, 2023

Proposed changes

Jira ticket: INTMDB-1169

Fix Atlas variables to use consistently: MONGODB_ATLAS_ORG_ID, MONGODB_ATLAS_PUBLIC_KEY, MONGODB_ATLAS_PUBLIC_KEY, MONGODB_ATLAS_BASE_URL instead of ATLAS_ORG_ID, etc.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Manual QA performed:

  • cfn invoke for each of CRUDL/cfn test
  • Updated resource in example
  • Published to AWS private registry
  • Used the template in example to create and update a stack in AWS
  • Deleted stack to ensure resources are deleted
  • Created multiple resources in same stack
  • Validated in Atlas UI
  • Included screenshots

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • For CFN Resources: I have released by changes in the private registry and proved by change
    works in Atlas

Further comments

@lantoli lantoli marked this pull request as ready for review October 16, 2023 11:15
@lantoli lantoli requested a review from a team as a code owner October 16, 2023 11:15
@lantoli lantoli added this pull request to the merge queue Oct 16, 2023
Merged via the queue into master with commit 67e58ee Oct 16, 2023
@lantoli lantoli deleted the INTMDB-1169_org_id branch October 16, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants