Fix shellcheck issues in the kubectl-mongodb plugin scripts #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejKaras
approved these changes
Jul 28, 2025
viveksinghggits
changed the title
|
Hi @Julien-Ben, |
Julien-Ben
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This RP fixes the shellcheck (info) issues that we saw in the
kubectl-mongodbplugin related scripts when we ranmake precommit.Most of the issues are fixed when I didn't actually have to make any change but I had to disable check for some lines where it was expected to make some change and I was not sure if that would impact things functionally.
Proof of Work
NA
Checklist