-
Notifications
You must be signed in to change notification settings - Fork 11
CLOUDP-333692: Re-design images building #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Julien-Ben
wants to merge
33
commits into
atomic-releases
Choose a base branch
from
julien-ben/ar-push-staging
base: atomic-releases
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combined Dockerfiles for MongoDB Kubernetes Operator Combined Dockerfiles for Init Ops Manager image Combined Dockerfiles for Init Database and Init AppDB Combined Dockerfiles for Database Combined Dockerfiles for upgrade-hook and readinessprobe Added agent Dockerfiles Created Dockerfile for OpsManager Removed Dockerfile.dcar and README.md about how to build it Add more gitgraphs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-design images building
Changes
Usage of standalone Dockerfiles
Added in a previous PR, they eliminate the need for templating, and make it possible to retire Sonar once the Epic is completed.
Building with docker buildx, multi-platform builds
In
build_images.py
we use docker buildx through a python API. It eliminates the need for building images separately for each platform, and manually bundling them in a manifest.Handle build environments explicitly,
Each build scenario, such as merge to master or a local patch, is handled and defined explicitly, at top level, in the main.py CLI. All options are inferred from the environment as before, but can be overridden through flags.
They define parameters such as registry, image tag, signing enabled ...
Proof of work
CI
Note
For the duration of the Atomic Releases epic, both pipelines will be in the repository, until we are done with the staging and promotion process. For now, this new system only work for patches (local, PR, merge to master).
Releases and daily builds still happen with the legacy
pipeline.py
, the functionlegacy_pipeline
was created in.evergreen-functions.yml
for this.Once the Epic is complete, we'll be able to remove:
pipeline.py