RUST-906 Add native support for AWS IAM Roles for service accounts, EKS in particular #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelatkinson
force-pushed
the
aws-iam-roles
branch
from
5c8535c to
9a59e02
Compare
isabelatkinson
commented
Jun 5, 2023
| .build() | ||
| .map_err(|e| Error::internal(format!("error initializing http client: {}", e)))?; | ||
| Ok(Self { inner }) | ||
| pub(crate) struct HttpRequest { |
There was a problem hiding this comment.
I refactored this file to match the design of reqwest's corresponding objects -- this made it easier to support queries without needing to pass None to all the existing HTTP requests in our code and to deserialize to arbitrary types.
There was a problem hiding this comment.
This is way nicer, thank you.
isabelatkinson
force-pushed
the
aws-iam-roles
branch
from
20e3271 to
29e6b50
Compare
isabelatkinson
commented
Jun 5, 2023
|
|
||
| source .evergreen/configure-rust.sh | ||
| rustup toolchain install nightly -c rustfmt | ||
| rustup default 1.69 |
There was a problem hiding this comment.
temporary fix to remove CI noise
abr-egn
approved these changes
Jun 6, 2023
| .build() | ||
| .map_err(|e| Error::internal(format!("error initializing http client: {}", e)))?; | ||
| Ok(Self { inner }) | ||
| pub(crate) struct HttpRequest { |
There was a problem hiding this comment.
This is way nicer, thank you.
isabelatkinson
force-pushed
the
aws-iam-roles
branch
from
c8cea47 to
d5e73ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.