RUST-2264 Fix handling of tlsInsecure in the URI #1453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelatkinson
commented
Aug 20, 2025
| )?; | ||
| } | ||
|
|
||
| if keys.contains(TLS_INSECURE) { |
There was a problem hiding this comment.
We don't currently parse tlsAllowInvalidHostnames (RUST-1896), but I added the logic for it here so that we have the validation once we support the option in the URI.
abr-egn
approved these changes
Aug 20, 2025
kevinAlbs
approved these changes
Aug 20, 2025
abr-egn
pushed a commit
to abr-egn/mongo-rust-driver
that referenced
this pull request
Aug 21, 2025
abr-egn
added a commit
that referenced
this pull request
Aug 21, 2025
Co-authored-by: Isabel Atkinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes handling of the
tlsInsecureoption in a URI.tlsInsecure=boolnow setsTlsOptions::allow_invalid_certificatesandTlsOptions::allow_invalid_hostnames(ifopenssl-tlsis enabled) to the value ofbool.Note that
tlsInsecurecan only be set via a URI; theConnectionStringandClientOptionstypes both store theTlsOptionstype, which only has fields for the more granular options.