RUST-2198 Add run_raw_command method
#1356
Conversation
|
@beckerinj thank you for this PR! I'll discuss this addition with the team early next week and get back to you on whether we would like to add this to the driver API. |
isabelatkinson
changed the title
run_raw_command method
fix docs don't change formatting
|
I suspected there are some other dependents which need changing under the different flags. |
|
I believe the latest commit should fix the |
src/action/run_command.rs
Outdated
| match session.transaction.state { | ||
| TransactionState::Starting | TransactionState::InProgress => { | ||
| if self.command.contains_key("readConcern") { | ||
| if command.get("readConcern").ok().is_some() { |
There was a problem hiding this comment.
| if command.get("readConcern").ok().is_some() { | |
| if command.get("readConcern").is_ok_and(|rc| rc.is_some()) { |
get returns an error if the document is malformed, so this as currently written will evaluate to true for any valid document
There was a problem hiding this comment.
Got it, made this change 👍
|
Apologies my formatter keeps auto formatting the imports, I just undid it again. |
There was a problem hiding this comment.
thanks for the formatting fix, lgtm! @abr-egn this is ready for your review
|
Cheers, no problem, I've made the requested changes and added the test. |
3 participants
The database
run_commandapi only takes a Document, while internally it is later converted to a RawDocumentBuf before execution. In a situation where you already have the command as a RawDocumentBuf in the first place, an unneeded conversion RawDocumentBuf -> Document -> RawDocumentBuf is required to use this API.I noticed that there was this
RunCommand::new_rawmethod, which was feature gated behind "in-use-encryption". I'm not sure the reason for this gate, but it's trivial to remove it and use it with the additionaldatabase.raw_run_commandmethod added here.I only added
raw_run_command, but a similarraw_run_cursor_commandcould also be added which takes RawDocumentBuf as well.