Skip to content

minor: skip sessions not supported tests on 8.1+ #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2025
Merged

minor: skip sessions not supported tests on 8.1+ #1312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc8fdc3
minor: skip sessions not supported test on 8.1+
isabelatkinson Feb 21, 2025
52c42fe
fix patchable
isabelatkinson Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .evergreen/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ buildvariants:

- name: gcp-kms
display_name: "GCP KMS"
# patchable: false
patchable: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this snuck in from my last PR

run_on:
# The GCP CLI is not available on RHEL/Ubuntu machines.
- debian11-small
Expand Down
6 changes: 4 additions & 2 deletions src/test/spec/sessions/sessions_not_supported.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,11 @@ use crate::{

async fn spawn_mongocryptd(name: &str) -> Option<(EventClient, Process)> {
let util_client = Client::for_test().await;
if util_client.server_version_lt(4, 2) {
// TODO RUST-1447: unskip on 8.1+
if util_client.server_version_lt(4, 2) || util_client.server_version_gte(8, 1) {
log_uncaptured(format!(
"Skipping {name}: cannot spawn mongocryptd due to server version < 4.2"
"Skipping {name}: cannot spawn mongocryptd due to server version < 4.2 or server \
version >= 8.1"
));
return None;
}
Expand Down