RUBY-3683 Fix CSOT for with_transaction #2941
Open
+100
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamis
previously approved these changes
Jul 18, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CSOT (Client-Side Operation Timeout) handling in the with_transaction method by properly supporting zero/infinite timeouts and refactoring deadline calculation logic.
Key Changes:
- Refactored deadline calculation into a separate
calculate_with_transaction_deadlinemethod that handlestimeout_ms: 0as infinite timeout - Added
deadline_expired?helper method to properly check deadline expiration, treating0as never expired - Added comprehensive test coverage for CSOT scenarios including zero timeout, positive timeout, and disabled CSOT
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| spec/mongo/session_transaction_spec.rb | Adds test coverage for CSOT with with_transaction, including tests for zero timeout (infinite), positive timeout values, and disabled CSOT scenarios |
| lib/mongo/session.rb | Refactors with_transaction to extract deadline calculation logic and properly handle infinite timeouts (when timeout_ms: 0), plus adds helper method for deadline expiration checks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.