RUBY-2619 Add test for security-sensitive commands #2286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-mongo
reviewed
Jun 29, 2021
Contributor
Author
|
Waiting for mongodb/specifications#1026 |
p-mongo
approved these changes
Jul 5, 2021
spec/runners/crud/requirement.rb
Outdated
| end | ||
| end | ||
| if @auth | ||
| ok &&= (@auth == cc.auth_enabled?) |
Contributor
There was a problem hiding this comment.
This should simply be ok &&= cc.auth_enabled?, the extra equality condition may fail if auth_enabled? returns a truthy but not true value.
comandeo
force-pushed
the
2619-sensitive-command-spec
branch
from
357cc32 to
76b4f92
Compare
alcaeus
pushed a commit
to alcaeus/mongo-ruby-driver
that referenced
this pull request
Jul 14, 2021
alcaeus
pushed a commit
that referenced
this pull request
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.