Skip to content

Conversation

NoahStapp
Copy link
Contributor

No description provided.

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot requested a review from Jibola May 2, 2024 21:56
@NoahStapp NoahStapp changed the title PYTHON-4372 Deprecate Python 3.7 PYTHON-4372 & PYTHON-4378 Deprecate Python 3.7 and Update supported PyPy Versions to 3.9 and 3.10 May 2, 2024
@blink1073
Copy link
Member

Other spots:

.github/workflows/release-python.yml:106:          python-version: '3.7'
.github/workflows/test-python.yml:56:        python-version: ["3.7", "3.11", "pypy-3.8"]
.github/workflows/test-python.yml:140:        python: ["3.7", "3.11"]
.github/workflows/test-python.yml:165:          python-version: '3.7'
.github/workflows/test-python.yml:197:            python-version: '3.7'
pyproject.toml:11:requires-python = ">=3.7"
pyproject.toml:33:    "Programming Language :: Python :: 3.7",

@NoahStapp
Copy link
Contributor Author

Other spots:

.github/workflows/release-python.yml:106:          python-version: '3.7'
.github/workflows/test-python.yml:56:        python-version: ["3.7", "3.11", "pypy-3.8"]
.github/workflows/test-python.yml:140:        python: ["3.7", "3.11"]
.github/workflows/test-python.yml:165:          python-version: '3.7'
.github/workflows/test-python.yml:197:            python-version: '3.7'
pyproject.toml:11:requires-python = ">=3.7"
pyproject.toml:33:    "Programming Language :: Python :: 3.7",

Good catch thanks, PyCharm search failed me.

@Jibola
Copy link
Contributor

Jibola commented May 3, 2024

Do we also want to update language on some comments?
https://github.com/NoahStapp/mongo-python-driver/blob/65968579d565b4f02f40fc803da325c0be6e8971/.evergreen/run-tests.sh#L250-L251

# Run the tests with coverage if requested and coverage is installed.
# Only cover CPython. PyPy reports suspiciously low coverage.
PYTHON_IMPL=$($PYTHON -c "import platform; print(platform.python_implementation())")
if [ -n "$COVERAGE" ] && [ "$PYTHON_IMPL" = "CPython" ]; then
    # coverage 7.3 dropped support for Python 3.7, keep in sync with combine-coverage.sh.
    # coverage >=5 is needed for relative_files=true.
    python -m pip install pytest-cov "coverage>=5,<7.3"
    TEST_ARGS="$TEST_ARGS --cov"
fi

Ex: 2
https://github.com/NoahStapp/mongo-python-driver/blob/65968579d565b4f02f40fc803da325c0be6e8971/pymongo/pool.py#L541

        # Combine the "driver" MongoClient option with PyMongo's info, like:
        # {
        #    'driver': {
        #        'name': 'PyMongo|MyDriver',
        #        'version': '4.2.0|1.2.3',
        #    },
        #    'platform': 'CPython 3.7.0|MyPlatform'
        # }
        if driver:
            if driver.name:
                self.__metadata["driver"]["name"] = "{}|{}".format(

@NoahStapp
Copy link
Contributor Author

CPython 3.7.0|

Good catches, fixed. Bumped our coverage max version now that we no longer need to support Python 3.7.

Copy link
Contributor

@Jibola Jibola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoahStapp NoahStapp merged commit 42f4503 into mongodb:master May 6, 2024
@NoahStapp NoahStapp deleted the PYTHON-4372 branch May 6, 2024 16:36
blink1073 pushed a commit to blink1073/mongo-python-driver that referenced this pull request Jun 7, 2024
…yPy Versions to 3.9 and 3.10 (mongodb#1630)

(cherry picked from commit 42f4503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants