-
Notifications
You must be signed in to change notification settings - Fork 266
draft: augment yaml definitions with test schema #1659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nirinchev
wants to merge
21
commits into
mongodb:v2.x
Choose a base branch
from
mongodb-js:ni/devtools-enhancements
base: v2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
39224b6
WIP
addaleax 56a801b
add tests schema
nirinchev 7e64509
Revert "add tests schema"
nirinchev 07cd9fc
run yamlfix
nirinchev 7cb2274
Reformat after running the js generator
nirinchev cb2571c
generate schema for accumulators
nirinchev e28803d
add test schemas for expressions
nirinchev fd06dd6
add test schemas for query
nirinchev 64a44ad
add search schemas
nirinchev 6a34eda
schema for stages
nirinchev cc2c832
Update with some refs
nirinchev c027132
type tweaks
nirinchev 3602303
fix names to align with docs
nirinchev 7978e4f
regenerate test schemas
nirinchev b9b1d19
add searchHighlight as a type
nirinchev c2b1ee5
Add schema for first/last
nirinchev 14623eb
make test name and pipeline required
nirinchev 943deb1
chore: update a few schemas
nirinchev 37a957c
add untypedPipeline type for pipelines that reference foreign collect…
nirinchev 34b9a20
Use proper tags instead of ejson syntax
nirinchev 4a2867b
correctly escape the regex dots
nirinchev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,11 +18,9 @@ tests: | |
pipeline: | ||
- $project: | ||
quizAvg: | ||
$avg: | ||
- $quizzes | ||
$avg: $quizzes | ||
labAvg: | ||
$avg: | ||
- $labs | ||
$avg: $labs | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These seem to have been errors, right? At least in the docs, those are field expressions rather than arrays. |
||
examAvg: | ||
$avg: | ||
- $final | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was conflicting with the docs, which say that it can be any expression. It was particularly problematic in the
$group
example since the actual input field doesn't need to be an array, it only becomes one in the context of a$group
, which is hard to statically enforce. I've relaxed the requirement in the interest of reducing the false negatives, at the cost of potentially accepting more false positives.