Ensure that AsyncReadWriteBinding is released prior to subscriber notification #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyemin
commented
Mar 1, 2021
Collaborator
Author
There was a problem hiding this comment.
Does anyone else find syncToCallback confusing? It seems more like the reverse, callbackToSink, makes more sense.
Member
There was a problem hiding this comment.
It converts the sink to a SingleResultCallback so makes sense to me.
Collaborator
Author
There was a problem hiding this comment.
I don't know what's going on with the indentation settings here.
…ification Previously the driver assumed that Mono#doOnTerminate is executed prior to the subscriber being notified of completion. But it turns out that behavior is not guaranteed in the Californium release of Project Reactor (though it is in later releases). So instead, now the SingleResultCallback that is used to notify the Mongo of completion is wrapped by one that first releases the binding, and Mono#doOnTerminate is no longer used. JAVA-4027
jyemin
changed the title
rozza
approved these changes
Mar 2, 2021
Member
rozza
left a comment
rozza
left a comment
There was a problem hiding this comment.
LGTM - did this cause any tests to fail?
Member
There was a problem hiding this comment.
It converts the sink to a SingleResultCallback so makes sense to me.
Collaborator
Author
|
Yes, see the analysis in JAVA-3969. It's the root cause of the failure of one of the sessions spec tests. |
Member
|
Good detective work :) |
stIncMale
reviewed
Mar 2, 2021
...tive-streams/src/main/com/mongodb/reactivestreams/client/internal/OperationExecutorImpl.java
Outdated
Show resolved
Hide resolved
stIncMale
approved these changes
Mar 2, 2021
stIncMale
approved these changes
Mar 2, 2021
jyemin
added a commit
that referenced
this pull request
Mar 2, 2021
…ification (#676) Previously the driver assumed that Mono#doOnTerminate is executed prior to the subscriber being notified of completion. But it turns out that behavior is not guaranteed in the Californium release of Project Reactor (though it is in later releases). So instead, now the SingleResultCallback that is used to notify the Mongo of completion is wrapped by one that first releases the binding, and Mono#doOnTerminate is no longer used. JAVA-4027
jfitzu
pushed a commit
to nextworld-tools/mongo-java-driver
that referenced
this pull request
Mar 3, 2021
…ification (mongodb#676) Previously the driver assumed that Mono#doOnTerminate is executed prior to the subscriber being notified of completion. But it turns out that behavior is not guaranteed in the Californium release of Project Reactor (though it is in later releases). So instead, now the SingleResultCallback that is used to notify the Mongo of completion is wrapped by one that first releases the binding, and Mono#doOnTerminate is no longer used. JAVA-4027
jfitzu
added a commit
to nextworld-tools/mongo-java-driver
that referenced
this pull request
Mar 3, 2021
…iber notification (mongodb#676)" This reverts commit 9bba683.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the driver assumed that Mono#doOnTerminate is executed
prior to the subscriber being notified of completion. But it turns
out that behavior is not guaranteed in the Californium release of
Project Reactor (though it is in later releases). So instead,
now the SingleResultCallback that is used to notify the Mongo of
completion is wrapped by one that first releases the binding, and
Mono#doOnTerminate is no longer used.
JAVA-4027