Skip to content

Conversation

rozza
Copy link
Member

@rozza rozza commented Oct 6, 2025

@rozza rozza requested a review from nhachicha October 6, 2025 15:33
@rozza rozza requested a review from a team as a code owner October 6, 2025 15:33
@rozza
Copy link
Member Author

rozza commented Oct 6, 2025

Changed the copy and paste for the javadocs and annotated all the core drivers libraries.

@nhachicha nhachicha requested a review from Copilot October 9, 2025 11:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes the annotation and documentation of internal packages across the MongoDB Java driver to clearly mark them as internal functionality that may change at any time.

  • Adds @Internal annotation to all internal package declarations
  • Standardizes package documentation to use consistent warning message
  • Removes package-specific documentation in favor of generic internal package warning

Reviewed Changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.

Show a summary per file
File Description
driver-sync/.../internal/package-info.java Added @internal annotation and standard warning message
driver-reactive-streams/.../internal/vault/package-info.java Replaced specific documentation with standard warning and added @internal annotation
driver-reactive-streams/.../internal/package-info.java Replaced specific documentation with standard warning and added @internal annotation
driver-reactive-streams/.../internal/gridfs/package-info.java Replaced specific documentation with standard warning and added @internal annotation
driver-reactive-streams/.../internal/crypt/package-info.java Replaced specific documentation with standard warning and added @internal annotation
driver-core/.../internal/validator/package-info.java Replaced incorrect documentation with standard warning and added @internal annotation
driver-core/.../internal/time/package-info.java Replaced specific documentation with standard warning and added @internal annotation
driver-core/.../internal/thread/package-info.java Replaced incorrect documentation with standard warning and added @internal annotation
driver-core/.../internal/session/package-info.java Replaced incorrect documentation with standard warning and added @internal annotation
driver-core/.../internal/selector/package-info.java Replaced incorrect documentation with standard warning and added @internal annotation
driver-core/.../internal/package-info.java Added standard warning message and @internal annotation
driver-core/.../internal/operation/retry/package-info.java Replaced incorrect documentation with standard warning and added @internal annotation
driver-core/.../internal/operation/package-info.java Replaced specific documentation with standard warning and added @internal annotation
driver-core/.../internal/logging/package-info.java Replaced incorrect documentation with standard warning and added @internal annotation
driver-core/.../internal/inject/package-info.java Replaced incorrect documentation with standard warning and added @internal annotation
driver-core/.../internal/function/package-info.java Added standard warning message and @internal annotation
driver-core/.../internal/event/package-info.java Replaced incorrect documentation with standard warning and added @internal annotation
driver-core/.../internal/dns/package-info.java Replaced incorrect documentation with standard warning and added @internal annotation
driver-core/.../internal/diagnostics/logging/package-info.java Replaced incorrect documentation with standard warning and added @internal annotation
driver-core/.../internal/connection/tlschannel/package-info.java Replaced detailed TLS Channel documentation with standard warning and added @internal annotation
driver-core/.../internal/connection/tlschannel/async/package-info.java Replaced specific documentation with standard warning and added @internal annotation
driver-core/.../internal/connection/package-info.java Replaced incorrect documentation with standard warning and added @internal annotation
driver-core/.../internal/connection/netty/package-info.java Replaced specific documentation with standard warning and added @internal annotation
driver-core/.../internal/client/vault/package-info.java Replaced incorrect documentation with standard warning and added @internal annotation
driver-core/.../internal/client/package-info.java Replaced specific documentation with standard warning and added @internal annotation
driver-core/.../internal/client/model/package-info.java Replaced incorrect documentation with standard warning and added @internal annotation
driver-core/.../internal/client/model/changestream/package-info.java Replaced incorrect documentation with standard warning and added @internal annotation
driver-core/.../internal/client/model/bulk/package-info.java Replaced specific documentation with standard warning and added @internal annotation
driver-core/.../internal/capi/package-info.java Replaced incorrect documentation with standard warning and added @internal annotation
driver-core/.../internal/bulk/package-info.java Replaced incorrect documentation with standard warning and added @internal annotation
driver-core/.../internal/binding/package-info.java Replaced incorrect documentation with standard warning and added @internal annotation
driver-core/.../internal/authentication/package-info.java Added standard warning message and @internal annotation
driver-core/.../internal/async/package-info.java Added standard warning message and @internal annotation
driver-core/.../internal/async/function/package-info.java Added standard warning message and @internal annotation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@nhachicha nhachicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍
I think we should keep the original description for the packages underneath the new mention WDYT?


/**
* This package enables the usage of TLS Channel as an {@link
* java.nio.channels.AsynchronousByteChannel}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you want to keep the internal description though?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

* <p>In other words, a simple library that allows the programmer to have TLS using the same
* standard socket API used for plaintext, just like OpenSSL does for C, only for Java, filling a
* specially painful missing feature of the standard Java library.
* This package contains internal functionality that may change at any time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@rozza rozza merged commit 0d34dfa into mongodb:main Oct 9, 2025
3 of 5 checks passed
@rozza rozza deleted the JAVA-5975 branch October 9, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants