Skip to content

Use OperationContext with NOOP Session #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025
Merged

Use OperationContext with NOOP Session #1733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6371d68
Use OperationContext with noop session.
vbabanin Jun 6, 2025
82a4333
Use default modifier.
vbabanin Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion driver-core/src/main/com/mongodb/internal/connection/Authenticator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public void reauthenticateAsync(final InternalConnection connection, final Opera
}).finish(callback);
}

private static OperationContext operationContextWithoutSession(final OperationContext operationContext) {
static OperationContext operationContextWithoutSession(final OperationContext operationContext) {
return operationContext.withSessionContext(
new ReadConcernAwareNoOpSessionContext(operationContext.getSessionContext().getReadConcern()));
}
Expand Down
4 changes: 2 additions & 2 deletions driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ static OidcCallback getGcpCallback(final MongoCredential credential) {
@Override
public void reauthenticate(final InternalConnection connection, final OperationContext operationContext) {
assertTrue(connection.opened());
authenticationLoop(connection, connection.getDescription(), operationContext);
authenticationLoop(connection, connection.getDescription(), operationContextWithoutSession(operationContext));
}

@Override
Expand All @@ -262,7 +262,7 @@ public void reauthenticateAsync(final InternalConnection connection,
final SingleResultCallback<Void> callback) {
beginAsync().thenRun(c -> {
assertTrue(connection.opened());
authenticationLoopAsync(connection, connection.getDescription(), operationContext, c);
authenticationLoopAsync(connection, connection.getDescription(), operationContextWithoutSession(operationContext), c);
}).finish(callback);
}

Expand Down