GODRIVER-2651 Break NoWritesPerformed-Only Error Sequence #1135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingyang-hu
reviewed
Dec 5, 2022
prestonvasquez
commented
Dec 6, 2022
| if tt.HasErrorLabel(NoWritesPerformed) && !errors.Is(tt, prevIndefiniteErr) { | ||
| err = prevIndefiniteErr | ||
|
|
||
| goto checkError |
There was a problem hiding this comment.
For clarity, this "goto" is defensive. One of the conditions for setting the "prevIndefiniteError" is that it is not the same type of error as the one that is the subject of this switch condition: "tt". If that is the case, we need to repeat the switch block for the "previousIndefiniteError" so that it can run the logic for the correct case.
If the "previousIndefiniteError" is the same as "tt", then there is no need to entire this block and the error can continue with its processing.
There was a problem hiding this comment.
Thank you for the explanation. It makes sense.
matthewdale
reviewed
Dec 7, 2022
qingyang-hu
approved these changes
Dec 8, 2022
| if tt.HasErrorLabel(NoWritesPerformed) && !errors.Is(tt, prevIndefiniteErr) { | ||
| err = prevIndefiniteErr | ||
|
|
||
| goto checkError |
There was a problem hiding this comment.
Thank you for the explanation. It makes sense.
Co-authored-by: Qingyang Hu <[email protected]>
benjirewis
reviewed
Dec 8, 2022
Co-authored-by: Benjamin Rewis <[email protected]>
benjirewis
approved these changes
Dec 8, 2022
prestonvasquez
added a commit
to prestonvasquez/mongo-go-driver
that referenced
this pull request
Dec 8, 2022
Co-authored-by: Qingyang Hu <[email protected]> Co-authored-by: Benjamin Rewis <[email protected]> Co-authored-by: Kevin Albertson <[email protected]> Co-authored-by: Qingyang Hu <[email protected]> Co-authored-by: Benjamin Rewis <[email protected]>
prestonvasquez
added a commit
that referenced
this pull request
Dec 8, 2022
* GODRIVER-2651 Break NoWritesPerformed-Only Error Sequence (#1135) Co-authored-by: Qingyang Hu <[email protected]> Co-authored-by: Benjamin Rewis <[email protected]> Co-authored-by: Kevin Albertson <[email protected]> Co-authored-by: Qingyang Hu <[email protected]> Co-authored-by: Benjamin Rewis <[email protected]> * GODRIVER-2333 Assert that Ping op succeeds initial DNS spec tests (#1124) * GODRIVER-2577 Retry heartbeat on timeout to prevent pool cleanup in FAAS pause. (#1133) * resolve merge conflicts Co-authored-by: Qingyang Hu <[email protected]> Co-authored-by: Benjamin Rewis <[email protected]> Co-authored-by: Kevin Albertson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2651
Summary
When a "NoWritesPerformed" label is encountered, and the executor is out of retries, then we need to reset the error to the "previousIndefiniteError" and re-run the error check. This also needs to work for cases where the only errors that are returned are labeled "NoWritesPerformed"
Background & Motivation
There are two issues that were noted: