Skip to content

CXX-2690 Deprecate sharded-replicaset topology type #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2023
Merged

CXX-2690 Deprecate sharded-replicaset topology type #975

merged 2 commits into from
Jun 13, 2023

Conversation

@joshbsiegel
Copy link
Contributor

@joshbsiegel joshbsiegel commented Jun 12, 2023

  • Searched through the changes made in https://jira.mongodb.org/browse/DRIVERS-2609 and updated the CXX tests where necessary without adding any tests that didn't exist before
  • Modified two instances where we previously had to decipher between sharded or sharded-replicaset type topology

@joshbsiegel joshbsiegel requested a review from kevinAlbs June 12, 2023 17:19
kevinAlbs
kevinAlbs reviewed Jun 12, 2023
View reviewed changes
@joshbsiegel joshbsiegel requested a review from kevinAlbs June 12, 2023 21:06
kevinAlbs
kevinAlbs approved these changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The task failures on Ubuntu 18.04 appear unrelated to these changes. The logs suggest an error installing a Python package as part of test setup here. I do not think that needs to block these changes.

@joshbsiegel joshbsiegel merged commit f7403c0 into mongodb:master Jun 13, 2023
@eramongodb eramongodb mentioned this pull request Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinAlbs kevinAlbs kevinAlbs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joshbsiegel @kevinAlbs