Silence MSVC warnings when including <bit> pre-C++20 #1448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1412.
Addresses the following annoyingly-aggressive warning emitted by STL
<bit>pre-C++20 despite using the__cpp_lib_endianfeature test macro correctly (CE):Conditioning on
__cplusplus >= 202002L(C++20) is not enough due to/Zc:__cplusplusissues somehow resulting in an even worse outcome (CE):Therefore,
_MSVC_LANG >= 202002Lis used instead, but only whendefined(_MSVC_LANG)is also true, since this is an MSVC-specific issue which is not applicable to other compilers (CE).