CXX-2812 enable abi-compatibility-check for stable ABI #1437
+23
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Aug 6, 2025
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
LGTM with swapping the if conditions.
| # curl -sS -d "${status:?}" -H "Content-Type: application/json" -X POST localhost:2285/task_status || true | ||
| declare ret | ||
| abi-compliance-checker -lib mongo-cxx-driver -old old.xml -new new.xml 2>&1 && ret="$?" || ret="$?" | ||
| if [[ "${ret:?}" -gt 0 ]]; then |
Collaborator
There was a problem hiding this comment.
Swap if blocks. I expect the -gt 1 block will never be entered (since the -gt 0 will be true too).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves CXX-2812. Following #1412, which defines and exports the first v1 ABI symbol
bsoncxx::v1::exception::~exception(), theabi-compliance-checkcan now support comparingv1symbols without errors (as followup to #1083). Unlike what was stated in #1083, it seems sufficient for the "new" library to contain at least one exported symbol; both the "old" and "new" libraries containing at least one exported symbol does not seem to be necessary.Drive-by improvements include:
== 1) from tool errors (> 1).mongocxx/v_noabi/config/*headers for consistency with bsoncxx and to avoid triggering the new v1 macro guard inclusion checks which are inherited by mongocxx.detailnamespace for both bsoncxx and mongocxx regardless of nesting.