Do not compile with system libmongoc during integration tests #1308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Jan 2, 2025
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
LGTM
Filed DEVPROD-13793.
Thank you for reporting. Suggest revising the request to instead remove mongo-c-driver install on macOS distros. mongo-c-driver was added in BUILD-10871 in an effort to add libmongocrypt. libmongocrypt was removed in BUILD-12527. I expect mongo-c-driver is no longer needed on macOS distros.
Contributor
Author
DEVPROD-13793 has been edited accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses recent Evergreen flaky test failures on MacOS distros due to unexpectedly compiling with a system-installed libmongoc (CMake reports version 1.29.1 despite
MONGOC_DOWNLOAD_VERSIONbeing 1.29.0). This leads to the libbson library having aBSON_EXTRA_ALIGNthat is inconsistent with test expectations. Filed DEVPROD-13793.This PR sets
CMAKE_DISABLE_FIND_PACKAGE_<PackageName>=ONwhen a preinstalled C Driver is not detected (the presence of thebson-config.hheader, as used by the extra alignment consistency checks). This forces CMake to "fail" to find an existing C Driver, thus ensuring it fetch-and-builds the C Driver as expected by integration tests.