Skip to content

Move stray bson_value::view type traits into detail namespace #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Move stray bson_value::view type traits into detail namespace #1263

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
551ac72
Move stray type traits into detail namespace
eramongodb Nov 11, 2024
83301da
Remove unused type trait
eramongodb Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/types/bson_value/view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,19 @@

#include <bsoncxx/config/prelude.hpp>

namespace bsoncxx {
namespace detail {

template <typename T>
using is_bson_view_compatible =
detail::conjunction<std::is_constructible<bsoncxx::v_noabi::types::bson_value::view, T>,
detail::negation<detail::disjunction<
detail::is_alike<T, bsoncxx::v_noabi::types::bson_value::view>,
detail::is_alike<T, bsoncxx::v_noabi::types::bson_value::value>>>>;

} // namespace detail
} // namespace bsoncxx

namespace bsoncxx {
namespace v_noabi {
namespace types {
Expand Down Expand Up @@ -303,15 +316,6 @@ class view {
};
};

template <typename T>
using is_bson_view_compatible = detail::conjunction<
std::is_constructible<bson_value::view, T>,
detail::negation<detail::disjunction<detail::is_alike<T, bson_value::view>,
detail::is_alike<T, bson_value::value>>>>;

template <typename T>
using not_view = is_bson_view_compatible<T>;

///
/// Compares a view with a type representable as a view.
///
Expand All @@ -322,28 +326,28 @@ using not_view = is_bson_view_compatible<T>;

/// @relatesalso bsoncxx::v_noabi::types::bson_value::view
template <typename T>
detail::requires_t<bool, is_bson_view_compatible<T>> //
detail::requires_t<bool, detail::is_bson_view_compatible<T>> //
operator==(const bson_value::view& lhs, T&& rhs) {
return lhs == bson_value::view{std::forward<T>(rhs)};
}

/// @relatesalso bsoncxx::v_noabi::types::bson_value::view
template <typename T>
detail::requires_t<bool, is_bson_view_compatible<T>> //
detail::requires_t<bool, detail::is_bson_view_compatible<T>> //
operator==(T&& lhs, const bson_value::view& rhs) {
return bson_value::view{std::forward<T>(lhs)} == rhs;
}

/// @relatesalso bsoncxx::v_noabi::types::bson_value::view
template <typename T>
detail::requires_t<bool, is_bson_view_compatible<T>> //
detail::requires_t<bool, detail::is_bson_view_compatible<T>> //
operator!=(const bson_value::view& lhs, T&& rhs) {
return lhs != bson_value::view{std::forward<T>(rhs)};
}

/// @relatesalso bsoncxx::v_noabi::types::bson_value::view
template <typename T>
detail::requires_t<bool, is_bson_view_compatible<T>> //
detail::requires_t<bool, detail::is_bson_view_compatible<T>> //
operator!=(T&& lhs, const bson_value::view& rhs) {
return bson_value::view{std::forward<T>(lhs)} != rhs;
}
Expand Down