CXX-3008 add instructions to examine Snyk reports during release #1139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
May 22, 2024
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
LGTM
Additionally updates
etc/requirements.txtwith output ofpip freezeto ensure dependencies are pinned, which should resolve some open Snyk issues.
I expect issues reported from etc/requirements.txt do not need to be resolved since they are not required by users of the shipped product. Pinning seems like an improvement nonetheless.
eramongodb
added a commit
that referenced
this pull request
Jun 24, 2024
* Also pin dependencies in etc/requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to CXX-3008. Additionally updates
etc/requirements.txtwith output ofpip freezeto ensure dependencies are pinned, which should resolve some open Snyk issues.