Update comment to more accurately reflect sharded cluster behavior #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
That may also be due to the unified test using the |
kevinAlbs
approved these changes
Nov 28, 2023
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
LGTM with a fix to lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SERVER-79306 clarified this is expected behavior. This PR updates the relevant comment accordingly to avoid misleading implications + to be consistency with the existing comment in aggregation_examples.cpp.
The equivalent unified spec test likely does not encounter this issue due to reuse of the
client0object used to create collections indatabase0during thecreateEntitiesstage, which adds entries to the logical session cache that are visible by the time the aggregate command is executed.