VS-99: Optimize MQL Generator to avoid having 1 using statement for each Bson Type #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisDog
requested changes
Jul 13, 2023
Comment on lines
25
to
27
| #pragma warning disable CS0169 // The field is never used | ||
| #pragma warning disable IDE0051 | ||
| private static readonly BsonTypeCustom123 s_dummyRef1; | ||
| private static readonly BsonTimeSpanCustom123 s_dummyRef2; | ||
| private static readonly BsonType s_dummyRef1; |
There was a problem hiding this comment.
Update the comment please to "// These fields are never used, they are needed to ensure that the relevant usings are not accidently removed"
|
|
||
| var fullTypeName = GetFullName(typeSymbol); | ||
| if (s_knownBsonTypes.TryGetValue(fullTypeName, out var knowTypeName)) | ||
| if (typeSymbol.IsSupportedBsonType() || typeSymbol.IsSupportedBsonSerializationOption()) |
There was a problem hiding this comment.
These methods perform ToDisplayString twice, while we already have fullTypeName.
Lets minimize the lookups and imbed IsSupportedBsonSerializationOption into IsSupportedBsonType (startsWith(NamespaceMongoDBBson)), and receive optional parameter fullTypeName.
BorisDog
approved these changes
Jul 14, 2023
| private static readonly HashSet<string> s_supportedBsonTypes = new() | ||
| { | ||
| "MongoDB.Bson.BsonDocument", | ||
| "MongoDB.Bson.BsonValue", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS-99: Optimize MQL Generator to avoid having 1 using statement for each Bson Type